fix(mincut): report exact results and qualify release claims - #1092
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicMinCut::recompute_min_cutalways calls the exact sparse Stoer–Wagner solver. Its legacy.approximate(ε)option changed onlyMinCutResult.is_exactandapproximation_ratio, so the same exact cut was mislabeled as approximate. This PR reports the algorithm actually run (is_exact: true, ratio1.0) while retaining the builder option and configuration fields for compatibility. A regression compares values, partitions, and labels across exact and legacy settings after graph updates.The public crate description, README, crate docs, and linked getting started/core concept guides now distinguish the exact polynomial recomputation path from separate research modules. Historical
n^0.12measurements and paper-component inventories are explicitly qualified;ApproxMinCut's ε-derived interval is described as heuristic rather than a certified all-graph bound. No benchmark result or paper implementation is claimed by this PR.This addresses the misleading result labeling and public claim portions of #988. It does not close the issue: push-to-main release gates, independent benchmark receipts, and release qualification still need separate work. The
fast-uriitem was already addressed by #1014 per the maintainer's issue comment.Reproduction and validation
.approximate(0.5)returnedis_exact: falsedespite matching the exact solver's value and partition.algorithm::tests::suite passed: 25 tests.subpolynomial::tests filtered; 26 doctests passed, 20 ignored.rustfmt --checkon changed Rust modules andgit diff --check: passed.The full workspace CI and long-running
subpolynomial::tests were not run locally. The reduced harness uses crates.io dependency resolution rather than the workspace lockfile; upstream CI remains the integration gate. NoLocalKCutsource from #1079 is changed.