presetBrowser: fix workbench mirror dropping decoded amp/block model names - #82
Open
ptn wants to merge 1 commit into
Open
presetBrowser: fix workbench mirror dropping decoded amp/block model names#82ptn wants to merge 1 commit into
ptn wants to merge 1 commit into
Conversation
The provided sample query of "All 5153 rigs" was not returning anything
at all on FM3, firmware 13. I did have about 10 presets that should have
matched it.
AMP(TYPE=...) queries (and simple free-text search) could never match a
real amp/block model because the workbench preset-browser mirror only
carried the generic roster instance label ("Amp 1") and the device model
string ("FM3") into matchEntryFromSummary, never the decoded per-family
model names ForgeFX sends separately (e.g. "5153 100W Blue"). Thread
summary.models/amps through AxisPresetBrowserEntrySummary and prefer them
over the generic label in matchEntryFromSummary and axisPbRowBlockChips,
matching src/lib/PresetBrowser.svelte's reference behavior.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provided sample query of "All 5153 rigs" was not returning anything at all on FM3, firmware 13. I did have about 10 presets that should have matched it.
AMP(TYPE=...) queries (and simple free-text search) could never match a real amp/block model because the workbench preset-browser mirror only carried the generic roster instance label ("Amp 1") and the device model string ("FM3") into matchEntryFromSummary, never the decoded per-family model names ForgeFX sends separately (e.g. "5153 100W Blue"). Thread summary.models/amps through AxisPresetBrowserEntrySummary and prefer them over the generic label in matchEntryFromSummary and axisPbRowBlockChips, matching src/lib/PresetBrowser.svelte's reference behavior.
Release
Merging to
mainreleases automatically — a singlerelease:*label controls it:docs/,.github/, or*.md→ no release)release:minor/release:major→ bigger bumprelease:none→ adopt without releasing (rides the next release)release:hold→ merge now, release laterrelease:hold/release:nonewin over a co-present bump labelpr-labelscheck enforces this)Versions come from tags — never bump
package.jsonin a PR. This repo releases with the-betasuffix (X.Y.Z-beta).Details: docs/RELEASING.md