Repository navigation
feat(config): isolate agent config directory, support hot reloading and plaintext key display - #50
Merged
Merged
Conversation
…nd plaintext key display - Config Isolation: isolate Pi agent configuration directory under <squid-config-dir>/agent via resolveAgentDirPath(), set PI_CODING_AGENT_DIR in daemon launch, and explicitly pass agentDir down to Pi session factory and resident agent instances. - Hot Reloading: mark provider, model, and apiKey settings as applies: 'now', allow dynamic provider get/set in ConfigService, and introduce restartAgent() in watch-session to hot reload live agent instances upon configuration updates without requiring a daemon restart. - Plaintext Config Display: render apiKey in plaintext in settings.slint and config-service for user visibility and immediate editability.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows the official Pi Agent API recommendations to address configuration isolation, dynamic hot reloading, and credential visibility in Squid's settings panel.
1. 配置隔离 (Configuration Isolation)
resolveAgentDirPath()insrc/config-paths.ts, isolating agent config files to<squid-config-dir>/agent(rather than colliding with global~/.pi/agent).process.env.PI_CODING_AGENT_DIR = agentDirduring daemon preparation insrc/squid-app.ts.agentDirparameter down throughsrc/watch-desktop.ts,src/watch-session.ts,src/resident-agent.ts, andsrc/pi-session-factory.ts.2. 支持热更新 (Hot Reloading)
provider,model, andapiKeyrows withapplies: "now"insrc/config-service.ts.getProvider()andsetProvider()inConfigServiceto handle dynamic model provider switching.restartAgent()insrc/watch-session.tswithrestartingstate preservation to hot-reload resident sessions without restarting the entire daemon.3. 配置明文显示 (Plaintext Config Display)
ui/settings.slintinput field toinput-type: InputType.text;.apiKeyrow inConfigServicewithkind: "text".readStoredCredentialKey()to send raw API keys to the panel.Verification
bun test).bun run ui:smoke) successfully validated window creation, accessibility status headers, and interactive confirmation flows.