Repository navigation
fix(gui): persist model config on save without clearing inputs and add guidance tooltips - #51
Merged
Merged
Conversation
- Prevent GUI settings inputs from being cleared on save by allowing endpoint fields (baseUrl, modelId) to persist without requiring an existing API key. - Fix UI refresh on save error in ui/src/main.rs so failed responses do not overwrite active form values with disk state. - Seed known provider defaults (OpenAI, DeepSeek, OpenRouter, Anthropic, Ollama, Bifrost) when switching modelProvider. - Add interactive help tooltip icon (?) with rich multi-provider examples on hover, persistent helper hints, and realistic placeholder text in settings.slint.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issue where configuring model settings (
apiKey,modelBaseUrl,modelId) in the GUI would wipe/clear inputs on save, and adds interactive guidance tooltips with multi-provider examples.Root Causes of Input Clearing
applyModelSetinsrc/config-service.tspreviously rejected savingmodelBaseUrlormodelIdif no credential was stored inauth.json.Incoming::ConfigResultinui/src/main.rsstill triggered a reload from disk, overwriting the user's input with the old empty values.modelProviderswitched to an empty provider dictionary inmodels.json, wiping all model fields in the dump.Key Changes
applyModelSet(src/config-service.ts) so developers can freely save Base URL, Model ID, and API keys independently.ui/src/main.rs, only triggerconfig_getreload whenresult.ok != 0, preventing field overwrites on save failure.KNOWN_PROVIDER_DEFAULTSfor OpenAI, DeepSeek, OpenRouter, Anthropic, Ollama, and Bifrost so switching providers populates standard defaults instead of blanking out.?): Added a circular hoverable?icon next to each setting title inui/settings.slintthat pops open a detailed card with examples for mainstream providers.Verification
bun test: All 812 tests passing.cargo test: All 102 UI unit tests passing.cargo check: UI builds cleanly.