Repository navigation
fix(ui): eliminate horizontal scrollbar overflow with responsive ScrollView bindings - #52
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the default window size (640x780), the UI panel suffered from an unwanted horizontal scrollbar across the main panel and in modal dialogs. This regression was caused by:
ScrollViewnot having viewport width constraints, allowing children (like long provider example strings and status notes) to report unconstrained preferred widths that exceeded the 640px window width.ScrollViewlacking horizontal scrollbar policy (ScrollBarPolicy.always-off).Solution
ScrollViewinui/panel.slint:content-width: sv.visible-width;horizontal-scrollbar-policy: ScrollBarPolicy.always-off;VerticalLayoutwidth withwidth: sv.visible-width;.preview-sv := ScrollViewand bounded text wrapping.wrap: word-wrap;to all tooltip text elements inui/settings.slint.Verification
bun run ui:smoke ui/target/debug/squid-ui) passed cleanly without any horizontal scrollbar.cargo test --manifest-path ui/Cargo.tomlpassed (12/12).bun testpassed (812/812).