Repository navigation
feat(input-suggest): proactive input suggestions & typing via official Pi Agent API - #54
Merged
Merged
Conversation
- Proactively trigger suggestions when focus moves to text inputs, editors, or terminals - Predict relevant text input and present confirmation prompt via ConfirmationCard - Auto-type accepted text into active window via cross-platform TextTypingService - Add GUI toggle in Settings (Screen group: inputSuggestions on/off, default on) - Support instant live hot reload via applies: 'now' in ConfigService - Full test coverage and virtual desktop visual smoke test verified
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
YoungSx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the proactive input suggestion feature with desktop confirmation, automated text typing, GUI controls, and alignment with official
@earendil-works/pi-coding-agentAPIs and patterns.Key Changes
type_text):src/type-text-tool.tsusingdefineTooland TypeBoxtypeTextParams.AbortSignalcancellation and structuredAgentToolResult<TypeTextToolDetails>.InlineExtension:src/input-suggestion-extension.tsconforming to Pi'sInlineExtensioninterface.type_textviapi.registerTool(...)and cleans up debounce states onsession_shutdown."type_text"intoACTING_TOOL_NAMESinsrc/resident-agent.tsso world-altering keyboard typing counts as an action (acted() = true).src/input-suggestion.tsto execute text typing via the officialToolDefinition.execute(...)pipeline when the user confirms with "Allow".event.kind === "focus_changed"event triggering mechanism insrc/watch-session.tsas explicitly requested.inputSuggestionstoggle inui/settings.slint,src/config-schema.ts, andsrc/config-service.ts(defaults totrue).Verification & Testing
tests/type-text-tool.test.ts,tests/input-suggestion-extension.test.ts,tests/input-suggestion.test.ts,tests/text-typing-service.test.ts,tests/resident-agent.test.ts.bun run typecheck(0 errors).bun test(840 pass, 7 skip, 0 fail).bun run ui:smokeon X11/Xvfb virtual desktop passed with screenshots verified.