Repository navigation
refactor(agent): architectural decoupling of input suggestion and typing service - #55
Merged
Merged
Conversation
…cture 1. Decoupled TextTypingExecutor domain interface from concrete TextTypingService. 2. Eliminated fake ToolDefinition.execute calls and dummy contexts in InputSuggestionService. 3. Decoupled inputSuggestionExtension to accept pure typeTextTool and Resettable lifecycle. 4. Cleaned up watch-session composition root into a strict acyclic DAG topology. 5. Handled tool abortion and typing errors defensively. 6. Expanded unit test suite and passed visual smoke tests.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses architectural decoupling and clean code practices around proactive desktop input suggestions and text typing services in Squid.
Key Architectural Improvements
Domain Abstraction for Text Typing ():
xdotool, macOSosascript, WindowsSendKeys).Eliminated Fake Tool Invocation ():
Decoupled Pi Extension & Lifecycle ():
Composition Root & Clean DAG Topology:
TextTypingService-> (InputSuggestionService,createTypeTextTool) ->inputSuggestionExtension.Defensive Error Handling:
Verification
bun run typecheckpassed with 0 errors across project and test configs.xvfb-run -a -s "-screen 0 1280x1024x24" bun run ui:smokepassed with full interactive confirmation flow.