Skip to content

PLASMA-8449: remove outline from DateItem & active border from TextArea - #3336

Closed
TitanKuzmich wants to merge 1 commit into
devfrom
PLASMA-8449
Closed

TitanKuzmich wants to merge 1 commit into
devfrom
PLASMA-8449

Conversation

@TitanKuzmich

@TitanKuzmich TitanKuzmich commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Core

TextArea

  • исправлен селектор для активного состояния

DatePicker

  • добавлен стиль для outline в Safari

What/why changed

TextArea

  • исправлен селектор для активного состояния

DatePicker

  • добавлен стиль для outline в Safari

Summary by CodeRabbit

  • Style
    • Calendar items now use transparent outlines on the item and its decorative element.
    • Text area active-state styling now applies only on devices with hover capability and a precise pointer, rather than on all devices. This changes when the active appearance is shown across different input types.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c51d8774-bf7c-4ecc-aed2-a721c4c265c5
Commits

Reviewing files that changed from the base of the PR and between 5f352b3 and 45e9c93.

Files selected for processing: 2
  • packages/plasma-new-hope/src/components/Calendar/ui/DateStructureItem/DateStructureItem.styles.ts
  • packages/plasma-new-hope/src/components/TextArea/variations/_view/base.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Calendar item styles add transparent outline colors. The TextArea active-state styles now apply only when the device matches the hover-and-fine-pointer media query.

Changes: Calendar outline styles

Layer / File(s) Summary
Add transparent outline colors
packages/plasma-new-hope/src/components/Calendar/ui/DateStructureItem/DateStructureItem.styles.ts
StyledItemRoot sets transparent outline colors on the root and its ::before pseudo-element.

TextArea active-state styles

Layer / File(s) Summary
Scope active-state styles to hover devices
packages/plasma-new-hope/src/components/TextArea/variations/_view/base.ts
The wrapper, container, and helpers receive active-state styles only when the (hover: hover) and (pointer: fine) media query matches.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: shuga2704

Merge Risk: Minimal · up to 45e9c

No concrete merge-blocking risk remains in these style changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies both main changes: removing the DateItem outline and changing the TextArea active border behavior.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TitanKuzmich
TitanKuzmich requested a review from IgorYar October 28, 2026 13:15
@TitanKuzmich

Copy link
Copy Markdown
Collaborator Author

/release-canary

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-3336/
landing: https://plasma.sberdevices.ru/pr/pr-3336/landing/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-3336/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-3336/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-3336/giga-storybook/
homeds storybook: https://plasma.sberdevices.ru/pr/pr-3336/homeds-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-3336/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-3336/web-storybook/
sdds-bizcom storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-bizcom-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-dfa-storybook/
sdds-finai storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-finai-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-insol-storybook/
sdds-insol-next storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-insol-next-storybook/
sdds-netology storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-netology-storybook/
sdds-os storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-os-storybook/
sdds-platform-ai storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-platform-ai-storybook/
sdds-sbcom storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-sbcom-storybook/
sdds-scan storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-scan-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-serv-storybook/
sdds-vc storybook: https://plasma.sberdevices.ru/pr/pr-3336/sdds-vc-storybook/

@Salute-Eva

Copy link
Copy Markdown
Contributor
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.402.0-canary.3336.40695181892.0
npm install @salutejs/plasma-b2c@1.644.0-canary.3336.40695181892.0
npm install @salutejs/plasma-colors@0.28.0-canary.3336.40695181892.0
npm install @salutejs/plasma-core@1.249.0-canary.3336.40695181892.0
npm install @salutejs/plasma-giga@0.371.0-canary.3336.40695181892.0
npm install @salutejs/plasma-homeds@0.371.0-canary.3336.40695181892.0
npm install @salutejs/plasma-hope@1.397.0-canary.3336.40695181892.0
npm install @salutejs/plasma-icons@1.257.0-canary.3336.40695181892.0
npm install @salutejs/plasma-new-hope@0.388.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens@1.160.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens-b2b@1.72.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens-b2c@0.83.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens-core@0.19.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens-web@1.87.0-canary.3336.40695181892.0
npm install @salutejs/plasma-typo@0.60.0-canary.3336.40695181892.0
npm install @salutejs/plasma-web@1.646.0-canary.3336.40695181892.0
npm install @salutejs/sdds-bizcom@0.376.0-canary.3336.40695181892.0
npm install @salutejs/sdds-cs@0.380.0-canary.3336.40695181892.0
npm install @salutejs/sdds-dfa@0.374.0-canary.3336.40695181892.0
npm install @salutejs/sdds-finai@0.367.0-canary.3336.40695181892.0
npm install @salutejs/sdds-icons@0.14.0-canary.3336.40695181892.0
npm install @salutejs/sdds-insol@0.371.0-canary.3336.40695181892.0
npm install @salutejs/sdds-insol-next@0.370.0-canary.3336.40695181892.0
npm install @salutejs/sdds-netology@0.375.0-canary.3336.40695181892.0
npm install @salutejs/sdds-os@0.46.0-canary.3336.40695181892.0
npm install @salutejs/sdds-platform-ai@0.375.0-canary.3336.40695181892.0
npm install @salutejs/sdds-sbcom@0.376.0-canary.3336.40695181892.0
npm install @salutejs/sdds-scan@0.374.0-canary.3336.40695181892.0
npm install @salutejs/sdds-serv@0.375.0-canary.3336.40695181892.0
npm install @salutejs/sdds-vc@0.10.0-canary.3336.40695181892.0
npm install @salutejs/core-themes@0.48.0-canary.3336.40695181892.0
npm install @salutejs/plasma-themes@0.70.0-canary.3336.40695181892.0
npm install @salutejs/sdds-themes@0.87.0-canary.3336.40695181892.0
npm install @salutejs/sdds-api-tests@0.33.0-canary.3336.40695181892.0
npm install @salutejs/plasma-cy-utils@0.179.0-canary.3336.40695181892.0
npm install @salutejs/plasma-sb-utils@0.251.0-canary.3336.40695181892.0
npm install @salutejs/plasma-tokens-utils@0.68.0-canary.3336.40695181892.0
# or 
yarn add @salutejs/plasma-asdk@0.402.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-b2c@1.644.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-colors@0.28.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-core@1.249.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-giga@0.371.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-homeds@0.371.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-hope@1.397.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-icons@1.257.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-new-hope@0.388.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens@1.160.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens-b2b@1.72.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens-b2c@0.83.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens-core@0.19.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens-web@1.87.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-typo@0.60.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-web@1.646.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-bizcom@0.376.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-cs@0.380.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-dfa@0.374.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-finai@0.367.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-icons@0.14.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-insol@0.371.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-insol-next@0.370.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-netology@0.375.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-os@0.46.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-platform-ai@0.375.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-sbcom@0.376.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-scan@0.374.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-serv@0.375.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-vc@0.10.0-canary.3336.40695181892.0
yarn add @salutejs/core-themes@0.48.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-themes@0.70.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-themes@0.87.0-canary.3336.40695181892.0
yarn add @salutejs/sdds-api-tests@0.33.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-cy-utils@0.179.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-sb-utils@0.251.0-canary.3336.40695181892.0
yarn add @salutejs/plasma-tokens-utils@0.68.0-canary.3336.40695181892.0

@TitanKuzmich

Copy link
Copy Markdown
Collaborator Author

clone of #3347

This branch was successfully deployed

1 active deployment
internal — 45e9c932 Deployed Oct 28, 2026 by TitanKuzmich via authorize / Approved #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants