You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
Shared Storybook utilities now create IconButton metadata and default stories. Seventeen package stories use the utilities, with selected packages retaining custom options or icon renderers.
Changes: IconButton Storybook stories
Layer / File(s)
Summary
Metadata and rendering helpers utils/plasma-sb-utils/src/components/IconButton/meta.ts, utils/plasma-sb-utils/src/components/IconButton/fixtures.ts, utils/plasma-sb-utils/src/components/IconButton/stories.tsx
Added helpers for metadata controls and default story rendering, plus fixtures for appearances and pin values.
Story generation and exports utils/plasma-sb-utils/src/components/IconButton/IconButton.tsx, utils/plasma-sb-utils/src/components/IconButton/index.ts, utils/plasma-sb-utils/src/components/index.ts
Added getIconButtonStories to combine component configuration, metadata, and a default story. Exported the utility through component indexes.
Standard package story migrations packages/plasma-b2c/.../IconButton.stories.tsx, packages/plasma-giga/.../IconButton.stories.tsx, packages/plasma-new-hope/.../IconButton.stories.tsx, packages/plasma-web/.../IconButton.stories.tsx, packages/sdds-bizcom/.../IconButton.stories.tsx, packages/sdds-dfa/.../IconButton.stories.tsx, packages/sdds-netology/.../IconButton.stories.tsx, packages/sdds-os/.../IconButton.stories.tsx, packages/sdds-sbcom/.../IconButton.stories.tsx, packages/sdds-scan/.../IconButton.stories.tsx, packages/sdds-serv/.../IconButton.stories.tsx
Replaced locally defined metadata and default stories with values from the shared generator.
Package-specific story options packages/plasma-homeds/.../IconButton.stories.tsx, packages/sdds-cs/.../IconButton.stories.tsx, packages/sdds-finai/.../IconButton.stories.tsx, packages/sdds-insol-next/.../IconButton.stories.tsx, packages/sdds-insol/.../IconButton.stories.tsx, packages/sdds-platform-ai/.../IconButton.stories.tsx
Migrated stories while retaining package-specific disabled props, defaults, controls, configurations, or icon-size rendering.
The shared IconButton story preserves the inspected outline behavior. No merge-blocking issue is established.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "PLASMA-7745: share IconButton stories" matches the main change. The PR moves the IconButton story logic into the shared plasma-sb-utils package through a new getIconButtonStories factory, a…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "PLASMA-7745: share IconButton stories" matches the main change. The PR moves the IconButton story logic into the shared plasma-sb-utils package through a new getIconButtonStories factory, and the vertical packages now import it. The title names the ticket, the component, and the action of sharing the stories. It omits the factory name, which the commit message gives, but it still names the primary change.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 23 files.
Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
ESLint install timed out. The project may have too many dependencies for the sandbox.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/why changed
IconButtom
Summary by CodeRabbit