Repository navigation
feat(search): add wallpaper blur behind option for pixel search - #1342
Balajitechlabs wants to merge 10 commits into
Conversation
a043097 to
1d785bd
Compare
sameerasw
left a comment
There was a problem hiding this comment.
This change breaks predictive back gesture
|
Thanks for catching this! Fixed in the latest commit 🥇 :} |
sameerasw
left a comment
There was a problem hiding this comment.
No this is not the behavior we had before. This is just custom hand made animations animating while listening to back gesture. Not the initial animations we had in the launcher open and close animation or the search from the widget.
If we can not fix predictive back gesture and animation, this change is not worth it. Because it breaks the whole flow of the searchbar to act as an overlay rather than the search opening right from the widget and then closing back into it.
e3b095d to
10350bd
Compare
|
Hey @sameerasw, updated! Removed the custom theme and back handler so the native widget animations and predictive back work properly. Tested on device and works great now. |
…ported features sheet
…dler for frosted glass
f233357 to
d003ee8
Compare
|
now shd work for you :) |
Description
Reworked this PR following review feedback to keep the native launcher feel intact.
Instead of overriding themes or handling back gestures manually in Compose (which broke the widget animations and predictive back), this keeps
Theme.Essentials.WallpaperTranslucentand simply toggles native window blur (FLAG_BLUR_BEHIND) behind the wallpaper.onResume/onNewIntentso toggling it applies right away.Type of change
UI changes
Checklist
Before submitting, please make sure:
develop(notmain)../gradlew assembleDebug../gradlew testDebugUnitTest.SettingsRepositoryfor keys and getter/setter methods.FeatureRegistry.ktfor search indexing.ui/core/(RoundedCardContainer,IconToggleItem, etc.).res/values/strings.xmland drawables use rounded variants (R.drawable.rounded_*).