Repository navigation
SOFAST Slice Plot Utility - #334
Conversation
jehsharp
left a comment
There was a problem hiding this comment.
The code looks good!
Try running this command in your OpenCSP directory and it should fix at least the black format test failing:
$ black -C -S .
I am also seeing some file not found errors for the ubi8-ci and windows2022-ci tests. Let me take a closer look at those.
jehsharp
left a comment
There was a problem hiding this comment.
Hey Alan, The ubi8 and Windows test are failing because there seems to be a missing docstring on line 614 of StandardPlotOutput.py (opencsp/common/lib/csp/StandardPlotOutput.py). If you add a simple docstring on that line, like:
"""Plots combined measured reference slopes"""
That should fix that failure.
|
Me and Alan worked on this, there was a problematic function call, it was a combined measured reference plot function issue. All tests are now passing, I will update the branch and get this merged in soon. |
5e50bd0 to
78fd06d
Compare
|
All tests are passing now and everything looks good, Thanks Alan! I will go ahead and merge into develop. |
Purpose
Adding slice plot utility to SOFAST post-processing.
Summary of changes
-Majority under StandardPlotOutput.py:
-Addition of curvature deviation as figure output
-Ability to save figure data (slope, slope deviation, curvature, curvature deviation, enclosed energy) as hdf5 output
-Addition of slice plot utility to generate multiple 2D slices in X or Y directions across slope/slope deviation/curvature/curvature deviation
-Addition of plot showing locations of slices
-Addition of plot showing comparison of measured and reference data for slope
-Addition of slice data saved as both hdf5 and csv output
-Addition of plot functionality for slice plot output including profile offsets and x-axis limits
-Addition of generic uncertainty bars to slice plot output figures (subject of future work)
-Update of ini file in sofast_fringe/single_facet example to support new changes
-Adjustments to VisualizeOrthorectifiedSlopeAbstract.py to allow data output
Implementation notes
-Additions tested using sofast_fringe/single_facet example.
Submission checklist
develop, notmainopencsp/test/test_DocStringsExist.pyare verified to include this change or have been updated accordinglydoc/are verified to include this change or have been updated accordingly