Repository navigation
Conversation
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
sharathb5
marked this pull request as ready for review
October 8, 2026 17:33
sharathb5
requested review from
bithckr,
dhunt3800,
dlawregiets and
rsperl
as code owners
October 8, 2026 17:33
rsperl
reviewed
Oct 8, 2026
rsperl
reviewed
Oct 8, 2026
rsperl
reviewed
Oct 8, 2026
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
rsperl
reviewed
Oct 8, 2026
| client *amqp.AMQPManagementClient | ||
| } | ||
|
|
||
| func newRabbitQueueManagementClient(connectionConfig *pb.ConnectionConfiguration) (*rabbitQueueManagementClient, error) { |
Contributor
There was a problem hiding this comment.
Why is the mgmt client duplicated here?
Contributor
Author
There was a problem hiding this comment.
ok I removed the integration-only client wrapper and now use the shared AMQPManagementClient.Request method for queue reads and cleanup.
Contributor
There was a problem hiding this comment.
If you need a mock mgmt client, use the testify mock package to implement the mgmt interface.
Contributor
There was a problem hiding this comment.
Actually I think this may be what you are looking for:
Let me know if you have questions on how to use it. It's pretty cool.
rsperl
reviewed
Oct 8, 2026
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
rsperl
reviewed
Oct 12, 2026
rsperl
reviewed
Oct 12, 2026
rsperl
reviewed
Oct 12, 2026
rsperl
reviewed
Oct 12, 2026
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
rsperl
reviewed
Oct 13, 2026
Signed-off-by: Sharath Bhattiprolu <sharathjb23@gmail.com>
rsperl
reviewed
Oct 13, 2026
| } | ||
|
|
||
| func queueSpecification(source *pb.Source) (rabbitmqamqp.IQueueSpecification, error) { | ||
| if source.GetType() == pb.Source_STREAM { |
Contributor
There was a problem hiding this comment.
I think it's fine to ignore streams for now since we'll soon implement streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AMQP 1.0 queue declaration with compatible queue options and coverage.