Skip to content

test(e2e): give the RUM flush-ladder test more wall-clock slack on slow runners #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krazymir merged 1 commit into from
Sep 23, 2026
Merged

test(e2e): give the RUM flush-ladder test more wall-clock slack on slow runners #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/web/e2e/rum.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ test.describe("real user monitoring (§32)", () => {
});

test("the flush ladder backs off while idle and snaps back to the floor on a click (§32.4)", async ({ page }) => {
test.slow(); // ~40 s of wall-clock waiting by design
test.slow(); // wall-clock waiting by design; extra so a slow runner still clears both polls below
const posts: number[] = [];
page.on("request", (r) => { if (r.url().includes("/api/rum") && r.method() === "POST") posts.push(Date.now()); });
await page.goto("/catalog");
Expand All @@ -174,15 +174,20 @@ test.describe("real user monitoring (§32)", () => {
const feeder = setInterval(() => { void page.evaluate(() => fetch("/api/stats").catch(() => {})).catch(() => {}); }, 1000);
try {
// Set [5, 7]: ticks at ~5 s (→ step 1), then every 7 s while idle. Wait for three beacons.
await expect.poll(() => posts.length, { timeout: 35_000, intervals: [500] }).toBeGreaterThanOrEqual(3);
// The poll budget (not the assertions below) is the slack for a slow runner: page-load/
// hydration and each request round-trip eat into the ~19 s the ladder itself needs before
// the 3rd beacon lands, and a loaded CI box can burn several extra seconds there without
// the ladder's own timing being wrong — give it real headroom rather than tightening the
// window and risking exactly this flake.
await expect.poll(() => posts.length, { timeout: 55_000, intervals: [500] }).toBeGreaterThanOrEqual(3);
const idleGap = posts[2]! - posts[1]!;
expect(idleGap, `idle beacons should be ≥ 7 s apart, got ${idleGap} ms`).toBeGreaterThanOrEqual(6_000);

// A click is a user action: the next beacon arrives within one floor (5 s) plus slack.
const n = posts.length;
const clickedAt = Date.now();
await page.getByRole("heading").first().click();
await expect.poll(() => posts.length, { timeout: 12_000, intervals: [250] }).toBeGreaterThan(n);
await expect.poll(() => posts.length, { timeout: 18_000, intervals: [250] }).toBeGreaterThan(n);
const snapGap = posts[n]! - clickedAt;
expect(snapGap, `after a click the next beacon should land within ~5 s, got ${snapGap} ms`).toBeLessThanOrEqual(8_000);
} finally {
Expand Down
Loading