Skip to content

refactor: extract SuggestionUIHandler from GeneralKeyboardIME (Part 11) (#426) #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewtavis merged 2 commits into from
Sep 13, 2026
Merged

refactor: extract SuggestionUIHandler from GeneralKeyboardIME (Part 11) (#426) #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
248eefe
refactor: extract SuggestionUIHandler from GeneralKeyboardIME (Part 1…
prince-0408 Aug 24, 2026
a9c2ff0
Remove changelog entry as not needed
andrewtavis Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,3 @@ Emojis for the following are chosen based on [gitmoji](https://gitmoji.dev/).
### ♻️ Code Refactoring

- Code quality improvements were continuously done to assure that the application is easy to maintain and meets Kotlin standards ([#426](https://github.com/scribe-org/Scribe-Android/issues/426)).
- `CommandHandler` was extracted from `GeneralKeyboardIME` to encapsulate command execution, Enter key dispatching, and lookup state machine logic ([#426](https://github.com/scribe-org/Scribe-Android/issues/426)).
- Introduced `KeyboardIMEContext` interface contract to decouple handler dependencies from the concrete `GeneralKeyboardIME` class ([#426](https://github.com/scribe-org/Scribe-Android/issues/426)).

2 changes: 2 additions & 0 deletions app/src/keyboards/java/be/scri/helpers/KeyboardIMEContext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import android.content.Context
import android.content.res.Resources
import android.view.inputmethod.InputConnection
import be.scri.databinding.InputMethodViewBinding
import be.scri.helpers.ui.KeyboardThemeManager
import be.scri.helpers.ui.KeyboardUIManager
import be.scri.models.ScribeLanguage
import be.scri.models.ScribeState
Expand Down Expand Up @@ -41,6 +42,7 @@ interface KeyboardIMEContext {

val binding: InputMethodViewBinding
val uiManager: KeyboardUIManager
val themeManager: KeyboardThemeManager
val isUiManagerInitialized: Boolean

val currentState: ScribeState
Expand Down
Loading
Loading