Gen queries from contacts and audit wd lexemes - #717
Draft
andrewtavis wants to merge 13 commits into
Draft
andrewtavis wants to merge 13 commits into
andrewtavis wants to merge 13 commits into
Conversation
Member
Author
|
Note: Tests expected to fail as I haven't been updating them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
This PR is being opened as a draft as I have way too many changes locally :)
Scribe-Data needs to shift in perspective towards first and foremost providing the data that Scribe needs. It was a poor decision on my end to push the project towards providing all the data, as this is causing maintainability issues. The goal for the scope is that it provides the data that Scribe applications need through generating queries from data contracts, and if the user wants to get all data, then it can audit Wikidata, create a simple contract for all the data, and then this contract can be used to generate the queries for all data. This functionality also means that for us it's dramatically easier to maintain the project as it's written in a way that the CLI itself can be used as a tool to expand its functionalities.
We'll thus be able to pass an argument to
getfor which query directory to use, with the default being the one within Scribe-Data that will have our queries. This PR also adds the functionality to generate queries from contracts and audit Wikidata for available lexemes for a language and data type. At time of opening the queries directory is being removed as I've deleted all queries, but I'll use the generation process to create them again before this PR is finalized.Related issue