refactor: drop pl.measure_obs in favor of spatialdata get_centroids#744
Draft
timtreis wants to merge 1 commit into
Draft
refactor: drop pl.measure_obs in favor of spatialdata get_centroids#744timtreis wants to merge 1 commit into
timtreis wants to merge 1 commit into
Conversation
spatialdata#1150 upstreams per-cell centroid/area persistence as SpatialData.get_centroids(..., persist_as="adata", return_area=True), making the prototype pl.measure_obs redundant. Remove measure_obs and its measure-specific helpers. The streaming label-centroid utilities (_stream_label_centroid_stats / _pixel_to_coord) stay - render.py's as_points path uses them. Delete the measure_obs tests. equivalent_diameter is no longer written; derive as 2*sqrt(area/pi). TEMPORARY: pin spatialdata to the get_centroids branch so CI tests the removal against the real upstream API. Do not merge until #1150 is released; revert the pin to a version constraint then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
pl.measure_obs; superseded bySpatialData.get_centroids(..., persist_as="adata", return_area=True)from scverse/spatialdata#1150.equivalent_diameteris no longer written (derive as2*sqrt(area/pi)).Blocked upstream / do not merge: temporarily pins
spatialdatato the #1150 branch so CI tests the removal against the real API. Revert the pin to a released version constraint once #1150 ships.