tool: fix child TCB cap inserted to wrong CNode #555
Merged
Conversation
We recently switched to using a 2 level CSpace for cap mapping support. During the switch there was a mistake in the code that caused a child TCB object to be inserted into the wrong CNode. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
A simple refactor that hide the different CNodes of a PD behind helper functions to make it less error prone during development. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
midnightveil
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently switched to using a 2 level CSpace for cap mapping support.
During the switch there was a mistake in the code that caused a child
TCB object to be inserted into the wrong CNode.
Closes #553