Skip to content

docs: add a Closes # line to the PR template - #87

Merged
karthickmk2001 merged 1 commit into
mainfrom
chore/pr-template-link-issue
Nov 11, 2026
Merged

karthickmk2001 merged 1 commit into
mainfrom
chore/pr-template-link-issue

Conversation

@karthickmk2001

@karthickmk2001 karthickmk2001 commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

What does this change, and why?

#45 and #47 were fully implemented in #60 and #61 (merged 2026-11-08), but both issues stayed open until 2026-11-11. The PRs never said Closes #45 / Closes #47, so GitHub had nothing to close. The PR template has no place for an issue link, so it's easy to miss. During the hackathon this matters more: an open, unassigned issue reads as available, so someone could pick up work that's already done.

  • .github/PULL_REQUEST_TEMPLATE.md: starts with a Closes # line and a short comment explaining it.
    CONTRIBUTING.md already asks for the link (its new Hackathon points section, from Add the hackathon contributor leaderboard #82), and the leaderboard only scores issues a merged PR closes. The template is where people actually write the description, so the line belongs there too.

No code changes.

Testing

  • pytest tests passes (no code changed)
  • ruff check . passes (no Python changed)
  • Added/updated tests for the behavior change (not applicable)

🤖 Generated with Claude Code

@karthickmk2001
karthickmk2001 force-pushed the chore/pr-template-link-issue branch 2 times, most recently from 9286b4b to 499d1f4 Compare November 11, 2026 20:35
@karthickmk2001 karthickmk2001 changed the title docs: ask PRs to link their issue with Closes #N docs: add a Closes # line to the PR template Nov 11, 2026
@karthickmk2001
karthickmk2001 force-pushed the chore/pr-template-link-issue branch from 499d1f4 to a8bee97 Compare November 11, 2026 20:35
#45 and #47 stayed open for days after #60 and #61 shipped them because neither PR linked its issue. CONTRIBUTING.md (from #82) already asks for the link and the leaderboard only scores linked issues, but the template had no place for it. Add the line so it is the default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@karthickmk2001
karthickmk2001 force-pushed the chore/pr-template-link-issue branch from a8bee97 to 1d5815a Compare November 11, 2026 21:36
@karthickmk2001
karthickmk2001 merged commit e3ef38d into main Nov 11, 2026
6 checks passed
@karthickmk2001
karthickmk2001 deleted the chore/pr-template-link-issue branch November 11, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant