Skip to content

docs(wallet-security): added separate section for dry-run recovery check - #631

Open
0xusmanf wants to merge 5 commits into
security-alliance:developfrom
0xusmanf:develop
Open

0xusmanf wants to merge 5 commits into
security-alliance:developfrom
0xusmanf:develop

Conversation

@0xusmanf

Copy link
Copy Markdown
Contributor

What does this PR change?

Added a separate section and explained different methods for Dry-run Recovery Check.

@pinalikefruit, kindly review the changes.

Type of change

  • New content
  • Edit to existing content
  • Outline / structure change
  • Typo or formatting fix
  • Tooling / config

If applicable

  • Editing existing content: tagged the current contributors from the attribution list
  • Framework has a steward: asked them to review
  • Outline change: updated vocs.config.ts with the dev: true parameter
  • Want community feedback: shared this PR in our Discord

Stuck on anything? Just write it here and we're happy to help.

@pinalikefruit
pinalikefruit requested review from pinalikefruit and removed request for pinalikefruit September 11, 2026 06:41

@frameworks-volunteer frameworks-volunteer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: x-ai/grok-4.6 Reasoning: medium Provider: openrouter

Security + QA review of the dry-run recovery section.

No secrets, injection, or unsafe code. CI is green. Native-app and wipe-and-restore guidance is sound, and the funds warning on wipe is the right constraint.

Requesting changes on Secondary Device.

That method currently says to import the seed onto a "secondary device" with no device class. On this same page, Key Generation already says not to import keys from a computer or another device, and never to store the seed digitally. A reader can take this as "type the seed into a laptop / hot wallet," which breaks the hardware-wallet model. If the intent is a second hardware wallet (or the later Backup Device), say that explicitly and forbid computers, phones, and software wallets.

Suggested wording: only another hardware wallet; enter the seed on that device's screen; compare receive addresses; never import the seed into a computer or hot wallet.

Non-blocking:

  • Link the Key Generation bullet "Perform dry-run recovery check" to the new section.
  • Add official Ledger Recovery Check / Trezor Check Backup URLs if you keep those product names.
  • Split the comma splice in the intro ("…during setup, that step…" → two sentences).

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
frameworks ✅ Ready (View Log) Visit Preview 9bfac68

@0xusmanf

Copy link
Copy Markdown
Contributor Author

I have implemented the changes suggested by @frameworks-volunteer

  • Corrected the wording from "Secondary Device" to "Backup Hardware Wallet".
  • Linked the Key Generation bullet "Perform dry-run recovery check" to the new section.
  • Added official Ledger Recovery Check / Trezor Check Backup URLs.
  • Split the comma splice in the intro ("…during setup, that step…" → two sentences).

@pinalikefruit pinalikefruit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @0xusmanf . Everything looks good to me @scode2277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants