Conversation
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: x-ai/grok-4.6 Reasoning: medium Provider: openrouter
Security + QA review of the dry-run recovery section.
No secrets, injection, or unsafe code. CI is green. Native-app and wipe-and-restore guidance is sound, and the funds warning on wipe is the right constraint.
Requesting changes on Secondary Device.
That method currently says to import the seed onto a "secondary device" with no device class. On this same page, Key Generation already says not to import keys from a computer or another device, and never to store the seed digitally. A reader can take this as "type the seed into a laptop / hot wallet," which breaks the hardware-wallet model. If the intent is a second hardware wallet (or the later Backup Device), say that explicitly and forbid computers, phones, and software wallets.
Suggested wording: only another hardware wallet; enter the seed on that device's screen; compare receive addresses; never import the seed into a computer or hot wallet.
Non-blocking:
- Link the Key Generation bullet "Perform dry-run recovery check" to the new section.
- Add official Ledger Recovery Check / Trezor Check Backup URLs if you keep those product names.
- Split the comma splice in the intro ("…during setup, that step…" → two sentences).
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
I have implemented the changes suggested by @frameworks-volunteer
|
pinalikefruit
left a comment
There was a problem hiding this comment.
Thanks for the contribution @0xusmanf . Everything looks good to me @scode2277
What does this PR change?
Added a separate section and explained different methods for Dry-run Recovery Check.
@pinalikefruit, kindly review the changes.
Type of change
If applicable
vocs.config.tswith thedev: trueparameterStuck on anything? Just write it here and we're happy to help.