Skip to content

Read exact execution receipt after uncertain claim - #979

Merged
GraciousGazelles merged 6 commits into
mainfrom
fix/runtime-proof-execution-receipt-read-20261022
Oct 22, 2026
Merged

GraciousGazelles merged 6 commits into
mainfrom
fix/runtime-proof-execution-receipt-read-20261022

Conversation

@GraciousGazelles

Copy link
Copy Markdown
Collaborator

Summary

If the fixed work-item claim request receives an uncertain response, the client now retains its request UUID and makes one bounded read for that exact operation using the same API bearer. A matching historical claim receipt settles the request as committed. Missing history, a malformed or mismatched receipt, or a failed read remains unresolved; the client never replays the claim.

The receipt lookup carries no claim proof. Regression coverage checks exact request binding, matching historical recovery, unresolved history, and the absence of claim replay.

Validation

  • Standalone rustfmt on the changed Rust files
  • git diff --check
  • Hosted validation is pending

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-22T10:42:26.970261Z 778c9ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to handle uncertain claim POST results by reading execution receipts from a new endpoint, /v0/work-items/execution-receipt/read. It adds the necessary deserialization structures, parsing logic, and asynchronous retrieval functions, updating send_claim_to_async to resolve claims using historical receipts while preventing unsafe replays. Comprehensive unit tests and documentation have also been added. The review feedback suggests improving code readability in send_claim_to_async by refactoring a complex chunk-reading loop into a more idiomatic Rust loop with match, and enhancing debuggability in parse_execution_receipt by preserving the JSON deserialization error in the returned error message.

Comment thread codex-rs/runtime-proof/src/api_claim.rs
Comment thread codex-rs/runtime-proof/src/api_claim.rs
@GraciousGazelles
GraciousGazelles added this pull request to the merge queue Oct 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 22, 2026
@GraciousGazelles
GraciousGazelles added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 00e2785 Oct 22, 2026
82 checks passed
@GraciousGazelles
GraciousGazelles deleted the fix/runtime-proof-execution-receipt-read-20261022 branch October 22, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant