refactor(ui): use headlessui flat named exports - #3453
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR migrates Headless UI compound component syntax to standalone named components across menus, transitions, listboxes, labels, and disclosures. Existing props, styling, rendering, and behavior remain unchanged. ChangesHeadless UI API migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates Headless UI imports and component references without intended behavior changes; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0053afe to
77950cb
Compare
The root Transition left on duration-300 while its Transition.Childe left on duration-500 sm:duration700. Headless UI keeps the subtree mounted until the child finishes, so from 300ms onward the root had completed its own transition and reverted to its base className (bg-gray-800/70 at full opacity) while the panel was still mid-slide, partially off the right edge. This aligns the root's leave duration to the child's so both finish together and the subtree unmounts with the backdrop still at opacity-0. The panel's motion is unchanged and this only affects the backdrop fade-out which never previously completely cleanly.
v2 deprecates dot notation in favour of flat named exports. Renamed all 70 dotted tags and updated the imports to match. This is behaviour-neutral.
77950cb to
b44603a
Compare
Description
v2 deprecates dot notation in favour of flat named exports. Renamed all 70 dotted tags across 12 files and update the imports to match. The dotted names are aliases of the same implementations, so this is behaviour-neutral.
How Has This Been Tested?
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit