fix(request): guard against null requestedBy to stop Discover crash and per-request 404s

[jrogers512]

Description

Replacing requestRepository.findOneOrFail with findOne plus an explicit 404 in the request routes, and guarding RequestCard against a null requestedBy, stops the Discover/request-list "Oops" crash and per-request errors that occur when a request's requestedById FK is NULL (e.g. after a user is removed from the app, leaving an orphaned FK).

The entity declares requestedBy as non-nullable, but orphaned rows still occur, so the code (which assumes non-null) must be hardened against it.

• Fixes the Discover / request-list page crash (null dereference on requestData.requestedBy).
• Fixes GET /api/v1/request/:id, retry, and status routes erroring/404ing for such requests.

How Has This Been Tested?

Confirmed against a live instance where requests 95/121/124 had requestedById = NULL:

• GET /api/v1/request/{id} returns 200 after the fix (was 404 before).
• Discover and request-list pages render without crashing.
• Ran the repo's prettier check against both changed files - clean.

Screenshots / Logs (if applicable)

N/A

Checklist:

• I have read and followed the contribution guidelines.
• Disclosed any use of AI (see our policy)
• I have updated the documentation accordingly.
• All new and existing tests passed.
• Successful build pnpm build
• Translation keys pnpm i18n:extract
• Database migration (if required)

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}