Skip to content

Add full domain partition monoid method in semiex.gi,gd,tst - #1229

Open
kpd-0 wants to merge 6 commits into
semigroups:mainfrom
kpd-0:FullDomain
Open

kpd-0 wants to merge 6 commits into
semigroups:mainfrom
kpd-0:FullDomain

Conversation

@kpd-0

@kpd-0 kpd-0 commented Oct 2, 2026

Copy link
Copy Markdown

Wrote method for FullDomainPartitionMonoid using generators. Changes in semiex.gi, semiex.gd, semiex.tst

@james-d-mitchell

Copy link
Copy Markdown
Collaborator

Thanks @kpd-0 ! This still needs some documentation, if you look in the file: doc/semiex.xml you can do a version of what you find there but for FullDomainPartitionMonoid instead. You'll also need to add <#Include Label = "FullDomainPartitionMonoid"/> in doc/z-chap07.xml so that the documentation you write in doc/semiex.xml is included in the manual.

To check that it works you can either do SemigroupsMakeDoc(); in GAP itself, or run gap makedoc.g in the gap/pkg/semigroups directory. The manual examples are run as part of the tests, which you can also check by doing SEMIGROUPS.TestManualExamples(); in GAP (this function also can take a number as an argument if you want to repeatedly run a single test).

@james-d-mitchell

Copy link
Copy Markdown
Collaborator

Also @kpd-0 you'll need to fix the failing CI jobs, clicking on the various links should indicate what has gone wrong. If you're not sure about anything then please ping me, and I'll try to help. (The CI didn't run automatically when you opened the PR because you've never contributed before, next submission it'll run automatically).

Comment thread tst/standard/semigroups/semiex.tst Outdated
@james-d-mitchell james-d-mitchell changed the title Add Full domain partition monoid method in semiex.gi,gd,tst Add full domain partition monoid method in semiex.gi,gd,tst Oct 7, 2026
Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
@kpd-0

kpd-0 commented Oct 9, 2026

Copy link
Copy Markdown
Author

Ought I to add a refrence to a bibliography file here?
I wasnt aware that was something that existed, but just seen that it does at least for libsemigroups

@james-d-mitchell

Copy link
Copy Markdown
Collaborator

Ought I to add a refrence to a bibliography file here? I wasnt aware that was something that existed, but just seen that it does at least for libsemigroups

Ah yes, good point, you should add something to doc/bibliography.xml.bib, thanks @kpd-0

@kpd-0

kpd-0 commented Oct 9, 2026

Copy link
Copy Markdown
Author

I made changes to the bibliography doc locally, but I'm unsure about it being pushed to the online version. I couldn't see it on git status or anyhting? Do you know if I need to make the change elsewhere?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants