Repository navigation
Accept new plist matrix view format in tests - #1237
Merged
james-d-mitchell merged 1 commit intoOct 16, 2026
Merged
Conversation
GAP 4.17 views matrices in IsPlistMatrixRep as <2x2 plist matrix over R> instead of <2x2-matrix over R> (gap-system/gap#6686), which broke the standard tests and four manual examples. Update the expected outputs to the new format and normalise the old one via a transformFunction in SEMIGROUPS.TestRec and in the manual example runner, so the tests pass with both old and new GAP. The transform can be removed once GAP < 4.17 is no longer supported. Assisted-by: Claude Code (Opus 5.5)
Collaborator
|
Thanks @fingolfin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAP 4.17 views matrices in IsPlistMatrixRep as
<2x2 plist matrix over R>instead of<2x2-matrix over R>(gap-system/gap#6686), which broke the standard tests and four manual examples.Update the expected outputs to the new format and normalise the old one via a
transformFunctioninSEMIGROUPS.TestRecand in the manual example runner, so the tests pass with both old and new GAP. The transform can be removed once GAP < 4.17 is no longer supported.Assisted-by: Claude Code (Opus 5.5)