Repository navigation
Conversation
`UnderlyingInjectionZeroMagma` is injective but not surjective: the adjoined zero is not in its image. GAP currently marks it bijective by mistake, which makes `x ^ InverseGeneralMapping( inj )` work. Once GAP fixes that (gap-system/gap#6767), the inverse is no longer total and `^` raises an error, breaking `IsomorphismPartialPermSemigroup` for zero groups. Use `PreImagesRepresentative` instead, which works with both old and fixed GAP versions. Assisted-by: Generative AI
fingolfin
force-pushed
the
mh/injectionzeromagma
branch
from
October 18, 2026 22:08
441f375 to
1cfdd6e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnderlyingInjectionZeroMagmais injective but not surjective: the adjoined zero is not in its image. GAP currently marks it bijective by mistake, which makesx ^ InverseGeneralMapping( inj )work. Once GAP fixes that (gap-system/gap#6767), the inverse is no longer total and^raises an error, breakingIsomorphismPartialPermSemigroupfor zero groups.Use
PreImagesRepresentativeinstead, which works with both old and fixed GAP versions.Assisted-by: Generative AI