Skip to content

Use preimages instead of inverse of zero injection - #1238

Open
fingolfin wants to merge 1 commit into
semigroups:stable-5.7from
fingolfin:mh/injectionzeromagma
Open

fingolfin wants to merge 1 commit into
semigroups:stable-5.7from
fingolfin:mh/injectionzeromagma

Conversation

@fingolfin

@fingolfin fingolfin commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

UnderlyingInjectionZeroMagma is injective but not surjective: the adjoined zero is not in its image. GAP currently marks it bijective by mistake, which makes x ^ InverseGeneralMapping( inj ) work. Once GAP fixes that (gap-system/gap#6767), the inverse is no longer total and ^ raises an error, breaking IsomorphismPartialPermSemigroup for zero groups.

Use PreImagesRepresentative instead, which works with both old and fixed GAP versions.

Assisted-by: Generative AI

`UnderlyingInjectionZeroMagma` is injective but not surjective: the
adjoined zero is not in its image. GAP currently marks it bijective by
mistake, which makes `x ^ InverseGeneralMapping( inj )` work. Once GAP
fixes that (gap-system/gap#6767), the inverse is no longer total and
`^` raises an error, breaking `IsomorphismPartialPermSemigroup` for
zero groups.

Use `PreImagesRepresentative` instead, which works with both old and
fixed GAP versions.

Assisted-by: Generative AI
@fingolfin
fingolfin force-pushed the mh/injectionzeromagma branch from 441f375 to 1cfdd6e Compare October 18, 2026 22:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant