Refactor: Call processDeliveryItem only on successful checkout#243
Open
sentry[bot] wants to merge 1 commit into
Open
Refactor: Call processDeliveryItem only on successful checkout#243sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 886 +3
Branches 67 67
=====================================
- Misses 883 886 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
MainFragment$BackendAPIException: Failed to init delivery workflowby modifying the Android client's checkout flow.Previously,
processDeliveryItemwas called unconditionally after any HTTP response from the/checkoutendpoint, including failures (e.g., 500s from the backend) or network exceptions. This led to the client throwing its ownBackendAPIExceptioneven when the primary issue was a backend problem.This change ensures that
processDeliveryItemis only invoked when the HTTP checkout request returns a successful (2xx) status code. For non-successful responses or network failures, the checkout transaction is simply marked asINTERNAL_ERRORwithout attempting to initiate the delivery workflow.Note: The underlying root cause of the 500 errors from the Flask backend (an
UnboundLocalErrordue toquantitiesbeing used before assignment) is not addressed in this client-side PR. This change improves the client's resilience and error handling for such backend failures.Fixes ANDROID-K7