refactor: simpler raw - #637
Merged
Merged
Conversation
Contributor
|
Do we know of anyone actually using/planning to use the internals feature? This might be annoying to those people, if they exist. Other than that, I do prefer |
Collaborator
Author
|
there are people interested in using the internals feature, you can look in issues at around #300 to #400, you'll probably find some they were things like it doesn't annoy anyone, brother the first version with this kind of internals was shipped yesterday hahahha |
Collaborator
Author
|
indeed internals dates back to #348 |
jdm
approved these changes
Sep 21, 2026
jdm
approved these changes
Sep 21, 2026
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
Signed-off-by: Alejandro Vaz <alejandro.vaz.myt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR moves the allocator from
RawSmallVectoSmallVec, replacingRawSmallVecfor the oldRawSmallVecInner, and adding the allocator directly toIntoIterit allows us to have a simpler internals API with a whole struct less, everything else stays the same
a safety guarantee to
RawSmallVec::try_grow_rawwas added, that the allocator must be the same the data is allocated incloses #635
it also adds a
Default for SmallVec<Type, N>implementation to make clippy stfukey idea:
RawSmallVecowns its data but not where it is (inline vs heap) nor where the heap is allocated (allocator)