Tests: Add system tests for groupadd in test_groupadd.py - #1695
Merged
ikerexxe merged 4 commits intoSep 3, 2026
Conversation
asakure
force-pushed
the
system_tests_groupadd_25_26_27
branch
from
July 22, 2026 18:34
f34312e to
159959b
Compare
asakure
force-pushed
the
system_tests_groupadd_25_26_27
branch
2 times, most recently
from
September 1, 2026 10:51
ff1df73 to
9522120
Compare
asakure
marked this pull request as ready for review
September 1, 2026 11:22
framework/hosts/shadow.py had a bug in the search pattern using 'grep'. \s is supposed to mean "whitespace", but without the -E flag, 'grep' treats \s as a literal backslash followed by the letter s. Since grep can't find the line, the code fails to replace the old value. Signed-off-by: Akshay Sakure <asakure@redhat.com> Suggested-by: Iker Pedrosa <ipedrosa@redhat.com>
This is Python transformation of the test located in `tests/grouptools/groupadd/25_groupadd_no_gshadow/groupadd.test` which checks that `groupadd` succeeds and creates group when /etc/gshadow file is not present. Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd_25_26_27
branch
from
September 2, 2026 11:01
9522120 to
ea2a272
Compare
ikerexxe
reviewed
Sep 3, 2026
asakure
force-pushed
the
system_tests_groupadd_25_26_27
branch
from
September 3, 2026 08:43
ea2a272 to
d480442
Compare
This is Python transformation of the test located in `tests/grouptools/groupadd/26_groupadd_-o_without_-g/groupadd.test` which checks that `groupadd` fails to create group when -o option is mentioned without -g option. Signed-off-by: Akshay Sakure <asakure@redhat.com>
This is Python transformation of the test located in `tests/grouptools/groupadd/27_groupadd_invalid_option/groupadd.test` which checks that `groupadd` command fails when invalid option is mentioned. Signed-off-by: Akshay Sakure <asakure@redhat.com>
asakure
force-pushed
the
system_tests_groupadd_25_26_27
branch
from
September 3, 2026 08:49
d480442 to
8868b1f
Compare
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add system tests for groupadd in test_groupadd.py for
existing bash tests with numbering 25, 26, 27.