Skip to content

Tests: Add system tests for groupadd in test_groupadd.py - #1725

Merged
ikerexxe merged 3 commits into
shadow-maint:masterfrom
asakure:system_tests_groupadd_17_18_19
Sep 7, 2026
Merged

Tests: Add system tests for groupadd in test_groupadd.py#1725
ikerexxe merged 3 commits into
shadow-maint:masterfrom
asakure:system_tests_groupadd_17_18_19

Conversation

@asakure

@asakure asakure commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Add system tests for groupadd in test_groupadd.py for
existing bash tests with numbering 17, 18, 19.

@asakure
asakure marked this pull request as draft August 25, 2026 11:38
@asakure
asakure force-pushed the system_tests_groupadd_17_18_19 branch 2 times, most recently from fc551cd to e7043cf Compare August 25, 2026 12:59
@asakure
asakure marked this pull request as ready for review August 26, 2026 04:57
@asakure
asakure force-pushed the system_tests_groupadd_17_18_19 branch from e7043cf to 5d435c3 Compare September 3, 2026 13:43

@ikerexxe ikerexxe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline

Comment thread tests/system/tests/test_groupadd.py Outdated
Comment thread tests/system/tests/test_groupadd.py Outdated
Comment thread tests/system/tests/test_groupadd.py Outdated
Comment thread tests/system/tests/test_groupadd.py Outdated
Comment thread tests/system/tests/test_groupadd.py Outdated
Comment thread tests/system/tests/test_groupadd.py Outdated
This is Python transformation of the test located in
`tests/grouptools/groupadd/17_groupadd_add_systemgroup/groupadd.test`
which checks that `groupadd` can create system group with GID from
the system GID range.

Signed-off-by: Akshay Sakure <asakure@redhat.com>
This is Python transformation of the test located in
`tests/grouptools/groupadd/18_groupadd_no_more_GID/groupadd.test`
which checks that `groupadd` fails to create group when all GIDs
in the range are exhausted.

Signed-off-by: Akshay Sakure <asakure@redhat.com>
@asakure
asakure force-pushed the system_tests_groupadd_17_18_19 branch from 5d435c3 to 807377b Compare September 4, 2026 09:33
@asakure
asakure requested a review from ikerexxe September 4, 2026 09:34
This is Python transformation of the test located in
`tests/grouptools/groupadd/19_groupadd_-r_no_more_system_GID/groupadd.test`
which checks that `groupadd` fails to create system group when
all GIDs in the range are exhausted.

Signed-off-by: Akshay Sakure <asakure@redhat.com>
@asakure
asakure force-pushed the system_tests_groupadd_17_18_19 branch from 807377b to 9a2f866 Compare September 4, 2026 09:39

@ikerexxe ikerexxe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ikerexxe
ikerexxe merged commit 0a1bdfd into shadow-maint:master Sep 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants