Skip to content

TEST: Add e2e tests for shp buildrun gather#402

Open
kaizakin wants to merge 1 commit into
shipwright-io:mainfrom
kaizakin:adde2etests
Open

TEST: Add e2e tests for shp buildrun gather#402
kaizakin wants to merge 1 commit into
shipwright-io:mainfrom
kaizakin:adde2etests

Conversation

@kaizakin

Copy link
Copy Markdown
Contributor

Changes

  • add e2e tests for shp buildrun gather

Related Issue

Fixes #401

Type of PR

/kind test
/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
Copilot AI review requested due to automatic review settings June 25, 2026 20:51
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2026
@openshift-ci openshift-ci Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2026
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@kaizakin: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • add e2e tests for shp buildrun gather

Related Issue

Fixes #401

Type of PR

/kind test
/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested a review from hasanawad94 June 25, 2026 20:51
@openshift-ci openshift-ci Bot requested a review from HeavyWombat June 25, 2026 20:51
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an end-to-end Bats test to validate the shp buildrun gather workflow, ensuring BuildRun diagnostics can be collected into a directory and packaged as an archive.

Changes:

  • Introduces an e2e test that creates a Build + BuildRun and runs shp buildrun gather to validate gathered artifacts.
  • Verifies log collection under the gathered diagnostics directory.
  • Adds coverage for --archive output behavior (creates .tar.gz and removes the expanded directory).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +41 to +43
assert_file_exist "${gather_dir}/buildrun.yaml"
assert_file_exist "${gather_dir}/taskrun.yaml"
assert_file_exist "${gather_dir}/pod.yaml"
Comment on lines +22 to +25
run shp build create ${build_name} \
--source-git-url=https://github.com/shipwright-io/sample-go \
--source-context-dir=source-build \
--output-image=${output_image}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add e2e tests for shp buildrun gather

3 participants