feat(calendar) | expose SDK options and restore card image widgets SPW-20290 - #77
amir-faghihi wants to merge 4 commits into
Conversation
marc-thomas
left a comment
There was a problem hiding this comment.
Requesting changes before this is merge/release-ready. The repository contributing guide and the WordPress Plugin release documentation require the release metadata and installable artifact to move with the code change.
Please complete the following:
-
Bump the plugin version (expected next patch version:
4.0.9, unless another release version has been agreed) by runningnode update-version.js <version>. This must update all three release identifiers:Versioninplugin/showpass-wordpress-plugin.phpSHOWPASS_PLUGIN_VERSIONinplugin/showpass-wordpress-plugin.phpStable taginplugin/readme.txt
This is also required to invalidate cached copies of the changed
showpass-custom.js; leaving it at4.0.8could cause updated sites to keep the old JavaScript and silently ignore the new shortcode parameters. -
Add the corresponding changelog entry to
plugin/readme.txt, covering both the calendar shortcode options and the card-image widget fixes now included in this PR. -
Regenerate and commit the root-level installable
showpass.zipafter the final source changes, followingCONTRIBUTING.md:git archive -o showpass.zip --prefix=showpass-wordpress-plugin/ HEAD:pluginPlease verify the archive contains the new
plugin/js/showpass-calendar-params.jsfile and all updated templates. -
Add actual validation evidence. This PR currently has no GitHub status/check runs. The checked-in Circle job only runs PHPUnit when Circle triggers; it does not run
npm run test:calendarornpm run test:card-images, and Circle has not created a build for either commit on this PR. -
WordPress.org/SVN deployment prerequisite: Amir needs to create a WordPress.org account and send Marc the WordPress.org username (not a password or credential). Marc can then add that account as a developer for the Showpass plugin so Amir can perform the documented SVN deployment: copy
plugin/to SVNtrunk, create the matchingtags/<version>directory, add new files, and commit the release.
References:
- Repository
CONTRIBUTING.md, sections “Make .zip file for plugin” and “Release to Wordpress SVN” - Technical Docs → WordPress Plugin → “Updating the Wordpress plugin”
|
One more release/CI item for this PR: CircleCI is running successfully on the branch, but the build now warns that config version 2.0 has reached end of life and will stop being supported. Could you please update the CircleCI config to version 2.1 in this PR and verify the PR pipeline still runs successfully? While updating it, please preserve the existing Composer/PHPUnit job and add the two JavaScript suites introduced/used here to CI:
An explicit 2.1 workflow containing the PHP and JavaScript test jobs would make it clear which checks are expected on every PR. Please include the successful CircleCI run in the PR verification notes afterward. |
|
Scope note: I piggybacked the card-image widget changes onto this PR to fix the issue reported in this Slack support thread. Event and membership card images appeared clickable but did nothing; these changes make the image open the same purchase widget as the title and “Buy Tickets” action while preserving external-link, detail-page, and sold-out behavior. |
Functional Changes
Local QA sign-off
Not applicable by Codex (automated checks passed; PHPUnit and a live WordPress smoke test were not available)
What is the change?
all), initial Special Events view, and multi-day start-date-only highlighting.Why the change is important?
How to test?
npm run test:calendarnpm run test:card-imagesnode --check plugin/js/showpass-calendar-params.jsnode --check plugin/js/showpass-custom.jsphp -l plugin/showpass-wordpress-plugin-shortcode.phpphp -l plugin/inc/default-grid.phpphp -l plugin/inc/default-list.phpphp -l plugin/inc/default-membership-grid.phpphp -l tests/CalendarShortcodeTest.php[showpass_calendar_widget]and[showpass_embed_calendar]in WordPress with the documented attributes.calendar_open_state="special-events"andcalendar_special_event="all"separately and together; verify omitted/invalid open-state values and returning to Calendar.Database Migrations
What is the reason for the migration(s) and impact on the database?
No database migrations.
Migration Approval
Not applicable by Codex (no migrations).
Additional Notes
The JavaScript calendar and card-image suites, PHP syntax checks, and direct PHP smoke checks for both calendar shortcodes passed. The plugin ZIP matches the updated source. PHPUnit is not installed; live WordPress QA is pending.
Deployment dependency: https://github.com/showpass/showpass-frontend/pull/7283 must be deployed with its rebuilt SDK before releasing this plugin update. The new options require the canonical calendar route; existing legacy routes do not implement them.