Skip to content

fix(sync): apply global rules last and keep syncing on failure - #215

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/sync-order-and-dead-skills
Oct 19, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/sync-order-and-dead-skills

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • sync: run ruler-dotdirs-sync first and ruler-apply-global last. Previously the dotdir rsync copied stale, gitignored repo-local Ruler outputs (from a 2026-09-25 project-scope apply) over the freshly generated ~/.claude/CLAUDE.md, Cursor/Windsurf/Kilo/IDX/Junie/Augment/OpenHands rules and several MCP configs, so rule changes such as feat(rules): include AI co-author trailer on agent commits #213 (AI co-author trailer) never reached agents.
  • sync: a failing step no longer aborts the remaining steps; the target still exits non-zero.
  • SKILLS.txt / skills-lock.json: drop 1password, bitwarden, credential-manager, full-stack-e2e-review, github from BetterWright; upstream now ships only browser, so skills-install failed on every run.

Verification

  • make sync exits 0; all 8 global Ruler instruction files contain the co-author rule.

🤖 Generated with Claude Code


Summary by cubic

Fixes the sync workflow so global rules are applied last and a failing step no longer aborts the remaining steps.

  • Previously, ruler-dotdirs-sync ran after ruler-apply-global and copied stale, gitignored repo-local Ruler outputs over the freshly generated global rule files and some MCP configs, so rule changes like the AI co-author trailer never reached agents.
  • Sync now runs every step, tracks failures, and exits non-zero at the end.
  • Removes 1password, bitwarden, credential-manager, full-stack-e2e-review, and github from SKILLS.txt/skills-lock.json; upstream BetterWright only ships browser, which made skills-install fail on every run.

Written for commit fd695c0. Summary will update on new commits.

View guided diff

ruler-dotdirs-sync ran after ruler-apply-global and copied stale
gitignored repo-local Ruler outputs over the fresh global files, so
~/.claude/CLAUDE.md and other agent rules never picked up rule changes.

- run ruler-dotdirs-sync first and ruler-apply-global last
- keep running remaining sync steps when one fails, exit non-zero at end
- drop BetterWright skills removed upstream (only browser remains),
  which made skills-install fail on every run

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shunkakinoki
shunkakinoki merged commit 8990316 into main Oct 19, 2026
1 check passed
@shunkakinoki
shunkakinoki deleted the fix/sync-order-and-dead-skills branch October 19, 2026 18:36
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c7616be9-4d95-4ec6-bf84-a2a3344545a8
📥 Commits

Reviewing files that changed from the base of the PR and between 1564f25 and fd695c0.

📒 Files selected for processing: 3
  • Makefile
  • SKILLS.txt
  • skills-lock.json
+-----------------------------------------------+
| Edge cases are just center cases in disguise. |
+-----------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant