Skip to content

fix(claude): stop adding Co-Authored-By trailers to commits - #3139

Merged
shunkakinoki merged 1 commit into
mainfrom
fix/claude-no-coauthor
Oct 20, 2026
Merged

shunkakinoki merged 1 commit into
mainfrom
fix/claude-no-coauthor

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Sets Claude Code attribution.commit to empty so the harness no longer appends a Co-Authored-By trailer. Pairs with shunkakinoki/dotagents#217, which removes the rule telling every agent to add one.

🤖 Generated with Claude Code


Summary by cubic

Stops Claude Code from adding Co-Authored-By trailers to commits by setting attribution.commit to an empty string in both Claude settings files. Pairs with shunkakinoki/dotagents#217, which removes the rule instructing agents to add the trailer.

Written for commit 2489976. Summary will update on new commits.

View guided diff Turn on auto-fix

@indent

indent Bot commented Oct 20, 2026

Copy link
Copy Markdown

Warning

This organization's free trial has ended, so Indent couldn't start this review. Manage billing to resume reviews on this repository.

Review agents

Select any unchecked box below to run or rerun that agent.

Pending (1)
  • Indent Review Agent · This agent has not run.
Full results

Indent Review Agent

  • Summary: This agent has not run.
  • Latest resultNo result — this agent has not run.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 831fd609-d42b-4c8f-acb1-c832909f2565
📥 Commits

Reviewing files that changed from the base of the PR and between 58edc40 and 2489976.

📒 Files selected for processing: 2
  • config/claude/settings.json
  • config/claude/settings.tpl.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Configuration
    • Added support for configuring commit attribution settings.
    • Applied the setting consistently across the default configuration and its template.

Both Claude settings files now include an attribution object with an empty commit value.

Changes: Claude settings

Layer / File(s) Summary
Add commit attribution setting
config/claude/settings.json, config/claude/settings.tpl.json
Both files define attribution.commit as an empty string.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 24899

No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly states that Claude configuration will stop adding Co-Authored-By trailers. This matches the main change.
Description check Passed The description accurately explains the attribution.commit configuration change in both settings files and its purpose.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the settings file.
An empty commit value waits.
Two configurations match.
No attribution is filled in.
The rabbit hops away.

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes: This PR adds "attribution": { "commit": "" } to config/claude/settings.json and config/claude/settings.tpl.json to prevent Claude Code from appending Co-Authored-By trailers to commits. The change is minimal and correctly applied to both the settings file and its template.

Pairs with shunkakinoki/dotagents#217, which removes the rule telling every agent to add the Co-Authored-By trailer.

No new issues found — the PR is ready to merge.

Pullfrog  | View workflow run | Using free | 𝕏

@shunkakinoki
shunkakinoki merged commit 4edba45 into main Oct 20, 2026
10 of 11 checks passed
@shunkakinoki
shunkakinoki deleted the fix/claude-no-coauthor branch October 20, 2026 03:31
@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

SHUN-25499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant