Repository navigation
fix(ai): drop blank text from Anthropic error tool results - #461
Merged
Merged
Conversation
An empty or whitespace-only text block in an is_error tool_result is a 400. Drop those items, and send a single [tool error] note when nothing remains.
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
No tracked issue. Follow-up to the merged sync in #458.
Type of change
What does this PR do?
An Anthropic
tool_resultwithis_error: trueis rejected when it contains an empty text block. Error lowering was always emitting the error value and every content item, so an empty string or whitespace-only text became"".Blank text items are now dropped. If nothing remains, the result is a single
[tool error]text block. Omission notes such as[image omitted]are kept.How did you verify your code works?
bun test test/provider/anthropic-messages.test.tsinpackages/ai: 85 pass, 0 fail. The new cases cover an empty-string error, an error whose only content is omitted media, and whitespace-only error text. Each asserts that every text block is non-blank.Visual
No UI change.
Screenshots / recordings
None.
Checklist