Repository navigation
Conversation
shym
force-pushed
the
refactor-load_path-2
branch
2 times, most recently
from
September 23, 2026 13:39
45846c4 to
57602fd
Compare
Pull the path-to-file cache logic into a `Path_cache` submodule Ported from oxcaml/oxcaml#2420 Co-authored-by: Andrei Odintsov <forestryks1@gmail.com>
Restrict the exported interface to what is actually used Add an internal interface for `Load_path.Dir` Ported from oxcaml/oxcaml#2420 Co-authored-by: Andrei Odintsov <forestryks1@gmail.com>
Normalization now does more than just uncapitalization so rename variables to follow that change
shym
force-pushed
the
refactor-load_path-2
branch
from
September 30, 2026 13:02
57602fd to
781d39c
Compare
Owner
Author
|
cc dra27-js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR works on
Load_pathto improve its structure by:Dirsubmodule to abstract away some of its implementation, both internally (by keeping its typetabstract) and externally (by removing some functions from its externally-visible interface),Path_cache, for itsLoad_path-internal cache.It also cleans up many names using the
_uncapsuffixes dating from before the current name-normalization functions.The structure part of this PR is a port from oxcaml/oxcaml#2420.
Suggestion: as usual when reviewing refactoring PRs, I find
git show --color-moved=dimmed-zebravery useful on mostly-shuffle-code-around commits.