Repository navigation
python(feat): add ABAC resource and principal attributes - #646
Merged
Merged
Conversation
wei-sift
requested review from
alexluck-sift,
brandonshippy-sift and
nathan-sift
June 22, 2026 00:06
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-646/ Deployed from |
wei-sift
marked this pull request as ready for review
June 22, 2026 00:09
nathan-sift
approved these changes
Jun 22, 2026
nathan-sift
left a comment
nathan-sift
left a comment
Contributor
There was a problem hiding this comment.
lgtm. There are some more user friendly additions we can consider in the future to make working with the API easier, but I don't think any of that is necessary or in scope for this PR.
alexluck-sift
pushed a commit
that referenced
this pull request
Jul 11, 2026
Bump version to 0.19.0 and update the changelog for the PRs merged since v0.18.0: ABAC attributes (#646), get_data cache improvements (#650), pytest docstring cleaning (#658), ULog data imports (#663), access control API grouping (#666), report templates (#672), download_file extra headers (#677), and the get_data pagination fix plus progress bars (#678). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5U49rrpvQm5bPbvEjR4xr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the public API for ABAC resource and principal attributes to
sift_client.client.resource_attributesmanages attribute keys on entities (assets, channels, runs).client.principal_attributesmanages keys on principals (users, user groups).The attribute key is the entry point: create or fetch a key, define enum values, then assign values to entities or principals.
SET_OF_ENUMassignments replace the full value set per target. Principal assignment accepts user IDs or emails, resolving emails to user IDs via REST since the gRPCUserproto has no email field.Also fixes
gen_pyi.pyto render enum parameter defaults as valid stub syntax.Test plan