Repository navigation
python(fix): allow patched filelock and drop pyOpenSSL - #855
Merged
Merged
Conversation
Widen the filelock pin to <5 so installs on Python 3.11+ resolve filelock 4.2.1 or later. Replace pyOpenSSL with the standard library ssl module for cert_via_openssl and remove the openssl extra, which capped cryptography below 42.
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-855/ Deployed from |
alexluck-sift
requested review from
marc-sift,
solidiquis and
wei-sift
and removed request for
wei-sift
October 26, 2026 19:28
alexluck-sift
marked this pull request as ready for review
October 26, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two dependency pins kept customer installs on releases with published vulnerabilities, even when fixed releases existed. This PR removes both blocks.
filelock
~=3.15to>=3.15,<5, so Python 3.11+ resolves filelock 4.2.1 or later (GHSA-v4x8-3wr5-3wq8, GHSA-9vhv-jxww-xfm5, GHSA-567q-5qvw-pf92). The SDK only usesAsyncFileLock, not the affectedReadWriteLockorSoftFileLock.pyOpenSSL removal
cert_via_opensslnow converts the system CA certificates to PEM withssl.DER_cert_to_PEM_certinstead of pyOpenSSL.opensslextra is removed. ItspyOpenSSL<24pin cappedcryptographybelow 42, which has several high-severity advisories.pip install sift-stack-py[openssl]still succeeds, with a warning that the extra does not exist.Verification
sift_clientandsift_pywithcert_via_openssl=Trueand no pyOpenSSL installed.