Repository navigation
Conversation
A time axis built from Run.start_time used microsecond integers while channel data uses nanoseconds, so interpolation produced NaN.
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-857/ Deployed from |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run.start_timeandRun.stop_timeare nanosecondpandas.Timestampvalues, the same resolution as channel data fromget_data.datetimevalues, and interpolation against channel data filled with NaN.datetime.pandas.Timestampis adatetimesubclass, and annotating the field asTimestampmakes pydantic refuse to build the model.Test plan
pytest lib/sift_client/_tests/sift_types/test_run.pycovers a sub-microsecond start, an exact-second stop, unset bounds,unit == "ns", and adate_rangewhose integer values match the start.ruff checkandruff format --checkon the changed files.date_rangeof these bounds isdatetime64[ns].date_rangeof the olddatetimebounds isdatetime64[us].