Skip to content

Scale buttons and list items on click - #2604

Merged
hahn-kev merged 1 commit into
developfrom
button-ux-tweak
Sep 1, 2026
Merged

Scale buttons and list items on click#2604
hahn-kev merged 1 commit into
developfrom
button-ux-tweak

Conversation

@hahn-kev

@hahn-kev hahn-kev commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Button animation:

Video.webm

List item animations:

Video.webm

Fully depressed entry list item:
image

Fully depressed project list item:
image

Fully depressed button:
image

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c0fe6da8-e524-4985-8804-47fde7edfa93

📥 Commits

Reviewing files that changed from the base of the PR and between 8fe33f0 and f6fe112.

📒 Files selected for processing (2)
  • frontend/viewer/src/lib/components/ListItem.svelte
  • frontend/viewer/src/lib/components/ui/button/button.svelte

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes add active-state scaling and transition styling to list item buttons and shared buttons. Button variants, properties, and rendering behavior remain unchanged.

Changes

Button activation feedback

Layer / File(s) Summary
Add active-state scaling
frontend/viewer/src/lib/components/ListItem.svelte, frontend/viewer/src/lib/components/ui/button/button.svelte
List item buttons and shared buttons scale to 95% while active. List items also use transition styling.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f6fe1

This PR makes localized visual interaction changes to buttons and list items; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit taps the button bright
It shrinks a little on the bite
The list item joins the play
With smooth small hops in soft display
Then springs back, neat and light

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: click scaling for buttons and list items.
Description check ✅ Passed The description documents the button and list item animations with supporting videos and images. It directly relates to the changeset.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch button-ux-tweak

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@argos-ci

argos-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 26, 2026, 7:45 AM
e2e (Inspect) ✅ No changes detected - Aug 26, 2026, 7:52 AM

@hahn-kev
hahn-kev requested a review from myieye August 31, 2026 10:09

@myieye myieye left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement IMO

@hahn-kev
hahn-kev merged commit 506130d into develop Sep 1, 2026
28 checks passed
@hahn-kev
hahn-kev deleted the button-ux-tweak branch September 1, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants