SF-3844 SF-3786 SF-3914 Clear Lynx insights of a checker that stops reporting - #4085
Merged
pmachapman merged 1 commit intoSep 15, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4085 +/- ##
==========================================
- Coverage 80.95% 80.95% -0.01%
==========================================
Files 664 664
Lines 42153 42158 +5
Branches 6945 6919 -26
==========================================
+ Hits 34125 34129 +4
- Misses 6864 6879 +15
+ Partials 1164 1150 -14 ☔ View full report in Codecov by Harness. |
Nateowami
temporarily deployed
to
screenshot_diff
September 3, 2026 02:42 — with
GitHub Actions
Inactive
Nateowami
force-pushed
the
fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights
branch
from
September 14, 2026 23:09
53570d0 to
9cf94dc
Compare
Nateowami
marked this pull request as ready for review
September 14, 2026 23:09
pmachapman
force-pushed
the
fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights
branch
from
September 15, 2026 00:37
9cf94dc to
e030508
Compare
pmachapman
self-requested a review
September 15, 2026 00:37
pmachapman
approved these changes
Sep 15, 2026
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
pmachapman
deleted the
fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights
branch
September 15, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real bug is that Lynx does not report when a diagnostic/checker no longer has any problems to report; it just stops reporting instead.
This solution is ugly, but it's better than keeping the bug, and I think a fix in Lynx would be non-trivial.
This change is