Skip to content

SF-3844 SF-3786 SF-3914 Clear Lynx insights of a checker that stops reporting - #4085

Merged
pmachapman merged 1 commit into
masterfrom
fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights
Sep 15, 2026
Merged

pmachapman merged 1 commit into
masterfrom
fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights

Conversation

@Nateowami

@Nateowami Nateowami commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

The real bug is that Lynx does not report when a diagnostic/checker no longer has any problems to report; it just stops reporting instead.

This solution is ugly, but it's better than keeping the bug, and I think a fix in Lynx would be non-trivial.

This change is Reviewable

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.95%. Comparing base (e06b6df) to head (e030508).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ate/editor/lynx/insights/lynx-workspace.service.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4085      +/-   ##
==========================================
- Coverage   80.95%   80.95%   -0.01%     
==========================================
  Files         664      664              
  Lines       42153    42158       +5     
  Branches     6945     6919      -26     
==========================================
+ Hits        34125    34129       +4     
- Misses       6864     6879      +15     
+ Partials     1164     1150      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami
Nateowami force-pushed the fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights branch from 53570d0 to 9cf94dc Compare September 14, 2026 23:09
@Nateowami
Nateowami marked this pull request as ready for review September 14, 2026 23:09
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Sep 14, 2026
@Nateowami
Nateowami deployed to screenshot_diff September 14, 2026 23:16 — with GitHub Actions Active
@pmachapman
pmachapman force-pushed the fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights branch from 9cf94dc to e030508 Compare September 15, 2026 00:37
@pmachapman pmachapman self-assigned this Sep 15, 2026
@pmachapman
pmachapman self-requested a review September 15, 2026 00:37
@pmachapman
pmachapman deployed to screenshot_diff September 15, 2026 00:44 — with GitHub Actions Active

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman
pmachapman merged commit 927235a into master Sep 15, 2026
29 checks passed
@pmachapman
pmachapman deleted the fix/SF-3844-SF-3786-SF-3914-lynx-stale-insights branch September 15, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants