SF-3595 Fix scrolling of selected verse into view in the source pane - #4097
Merged
Merged
Conversation
Nateowami
temporarily deployed
to
screenshot_diff
September 10, 2026 03:08 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4097 +/- ##
==========================================
+ Coverage 80.94% 80.95% +0.01%
==========================================
Files 664 664
Lines 42153 42153
Branches 6944 6917 -27
==========================================
+ Hits 34121 34126 +5
- Misses 6867 6879 +12
+ Partials 1165 1148 -17 ☔ View full report in Codecov by Harness. |
Contributor
|
📸 Screenshot diff deployed! (1 change) View the visual diff at: https://pr-4097--sf-screenshot-diffs.netlify.app |
Nateowami
force-pushed
the
fix/SF-3595-source-verse-scroll
branch
from
September 10, 2026 16:21
a9d3a9c to
fac1083
Compare
Nateowami
temporarily deployed
to
screenshot_diff
September 10, 2026 16:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Nateowami
marked this pull request as ready for review
September 11, 2026 02:47
Nateowami
added
testing complete
pmachapman
self-requested a review
September 13, 2026 21:27
pmachapman
force-pushed
the
fix/SF-3595-source-verse-scroll
branch
from
September 13, 2026 21:27
fac1083 to
5b4d0cd
Compare
pmachapman
approved these changes
Sep 13, 2026
pmachapman
left a comment
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is