Skip to content

SF-3917 Add a link to Low Draft Quality banner - #4104

Merged
RaymondLuong3 merged 3 commits into
masterfrom
fix/SF-3917
Sep 24, 2026
Merged

RaymondLuong3 merged 3 commits into
masterfrom
fix/SF-3917

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

See also:


This change is Reviewable

@pmachapman pmachapman added testing not required do not merge See PR description and/or comments for explanation labels Sep 14, 2026
@pmachapman
pmachapman deployed to screenshot_diff September 14, 2026 22:49 — with GitHub Actions Active
@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.00%. Comparing base (82e5153) to head (f6d1d75).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4104   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         664      664           
  Lines       42328    42331    +3     
  Branches     6988     6965   -23     
=======================================
+ Hits        34286    34292    +6     
- Misses       6876     6890   +14     
+ Partials     1166     1149   -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Waiting on the understanding-draft-quality help page to be made available before merging.

@RaymondLuong3 reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 self-assigned this Sep 15, 2026
@Nateowami

Copy link
Copy Markdown
Collaborator

Looking at the diff makes me think this really should be a reusable component so we don't have strings and logic repeated several places.

@pmachapman

Copy link
Copy Markdown
Collaborator Author

Looking at the diff makes me think this really should be a reusable component so we don't have strings and logic repeated several places.

@Nateowami Done - it was a bit more work than I expected, but I think it is simpler now.

@github-actions

Copy link
Copy Markdown
Contributor

📸 Screenshot diff deployed! (3 changes)

View the visual diff at: https://pr-4104--sf-screenshot-diffs.netlify.app

@Nateowami

Copy link
Copy Markdown
Collaborator

@RaymondLuong3 This is ready for re-review. Also the URL to the help site will need to be updated before we merge. But the help site article is live.

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 15 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@RaymondLuong3 RaymondLuong3 removed the do not merge See PR description and/or comments for explanation label Sep 24, 2026
@RaymondLuong3
RaymondLuong3 deployed to screenshot_diff September 24, 2026 18:11 — with GitHub Actions Active
@RaymondLuong3
RaymondLuong3 merged commit 2fb4dfd into master Sep 24, 2026
29 of 30 checks passed
@RaymondLuong3
RaymondLuong3 deleted the fix/SF-3917 branch September 24, 2026 18:18

This branch was successfully deployed

1 active deployment
screenshot_diff — f6d1d75a Deployed Sep 24, 2026 by RaymondLuong3 via Compare Screenshots #951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants