Skip to content

Remove a couple null-forgiving operators in MachineApiService #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmachapman merged 1 commit into from
Sep 14, 2026
Merged

Remove a couple null-forgiving operators in MachineApiService #4105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/SIL.XForge.Scripture/Services/MachineApiService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,10 +1529,9 @@
if (
buildProjectEvent?.Payload?.TryGetValue("buildConfig", out BsonValue? buildConfigBson) == true
&& buildConfigBson != null
&& JsonConvert.DeserializeObject<BuildConfig>(buildConfigBson.ToJson()) is { } buildConfig
)
{
BuildConfig buildConfig = JsonConvert.DeserializeObject<BuildConfig>(buildConfigBson.ToJson())!;

// Look up project snapshots for any referenced project IDs not already cached
HashSet<string> referencedProjectIds =
[
Expand Down Expand Up @@ -3453,7 +3452,7 @@
}

// Get the parallel corpus id
string? parallelCorpusId = projectSecret.ServalData!.ParallelCorpusIdForPreTranslate;
string? parallelCorpusId = projectSecret.ServalData?.ParallelCorpusIdForPreTranslate;
Comment thread
pmachapman marked this conversation as resolved.
Dismissed
if (string.IsNullOrWhiteSpace(parallelCorpusId))
{
throw new DataNotFoundException("The parallel corpus ID cannot be found.");
Expand Down
Loading