Update Storybook to 10.6 to fix dependency thrashing - #4147
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4147 +/- ##
=======================================
Coverage 81.01% 81.01%
=======================================
Files 664 664
Lines 42336 42336
Branches 6996 6996
=======================================
Hits 34299 34299
Misses 6874 6874
Partials 1163 1163 ☔ View full report in Codecov by Harness. |
e5f51ca to
05b2102
Compare
05b2102 to
058639f
Compare
pmachapman
left a comment
There was a problem hiding this comment.
I think this is really a bug in pnpm.
Agreed - it only started happening after the most recent update.
since the solution is updating Storybook and we'd need to do that anyway at some point, I'm not inclined to try to look into it too deeply.
Thank you - I had tried to update Storybook before 10.6 weas released and kept encountering GHA failures due to some weird exception thrown deliberately to prevent Storybook from running on WSL.
@pmachapman reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
esbuildpnpm installs for Storybook appears to be thrashing back and forth with each audit fix (See the table below, which shows the trashing. Disclaimer: AI generated and I only spot-checked it)esbuildI haven't fully researched the exact reasons for the version thrashing, or fully verified that this will fix it, but since the solution is updating Storybook and we'd need to do that anyway at some point, I'm not inclined to try to look into it too deeply.
I think this is really a bug in pnpm.
This change is