Skip to content

Update Storybook to 10.6 to fix dependency thrashing - #4147

Merged
pmachapman merged 1 commit into
masterfrom
update/storybook-10.6
Sep 27, 2026
Merged

pmachapman merged 1 commit into
masterfrom
update/storybook-10.6

Conversation

@Nateowami

@Nateowami Nateowami commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator
  1. The version of esbuild pnpm installs for Storybook appears to be thrashing back and forth with each audit fix (See the table below, which shows the trashing. Disclaimer: AI generated and I only spot-checked it)
  2. This PR updates Storybook, which shouuld fix this thrashing, because it specifies newer version of esbuild

I haven't fully researched the exact reasons for the version thrashing, or fully verified that this will fix it, but since the solution is updating Storybook and we'd need to do that anyway at some point, I'm not inclined to try to look into it too deeply.

I think this is really a bug in pnpm.

Date Change pnpm in workflow Storybook's esbuild Diff
2026-07-09 #3966 SF-3821 Switch to pnpm (lockfile created) – 0.27.7 lockfile L19018 ¹
2026-07-20 #3989 bot 11.10 0.27.7 → 0.27.2 (audit fix) diff
07-22 – 09-14 11 bot PRs, #3994 … #4092 11.10 0.27.2 (unchanged) –
2026-09-16 #4106 Update to pnpm 12.3.4, update vulnerable dependencies (manual) 11.10 → 12.3.4 0.27.2 → 0.27.7 lockfile L18384 ¹
2026-09-21 #4125 bot 12.3.4 0.27.7 → 0.27.2 (audit fix) lockfile L18402 ¹
2026-09-22 #4128 bot 12.3.4 0.27.2 → 0.27.7 (update) diff
2026-09-23 #4133 bot 12.3.4 0.27.7 → 0.27.2 (audit fix) diff
2026-09-24 #4138 bot 12.3.4 0.27.2 → 0.27.7 (update) diff
2026-09-24 #4141 bot (open) 12.3.4 0.27.7 → 0.27.2 (audit fix) diff

This change is Reviewable

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.01%. Comparing base (f8702a8) to head (058639f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4147   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files         664      664           
  Lines       42336    42336           
  Branches     6996     6996           
=======================================
  Hits        34299    34299           
  Misses       6874     6874           
  Partials     1163     1163           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami
Nateowami deployed to screenshot_diff September 25, 2026 02:26 — with GitHub Actions Active
@Nateowami
Nateowami marked this pull request as ready for review September 25, 2026 17:05
@Nateowami
Nateowami force-pushed the update/storybook-10.6 branch from e5f51ca to 05b2102 Compare September 25, 2026 17:05
@Nateowami
Nateowami deployed to screenshot_diff September 25, 2026 17:12 — with GitHub Actions Active
@pmachapman
pmachapman force-pushed the update/storybook-10.6 branch from 05b2102 to 058639f Compare September 27, 2026 18:47
@pmachapman
pmachapman self-requested a review September 27, 2026 18:47
@pmachapman pmachapman self-assigned this Sep 27, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I think this is really a bug in pnpm.

Agreed - it only started happening after the most recent update.

since the solution is updating Storybook and we'd need to do that anyway at some point, I'm not inclined to try to look into it too deeply.

Thank you - I had tried to update Storybook before 10.6 weas released and kept encountering GHA failures due to some weird exception thrown deliberately to prevent Storybook from running on WSL.

@pmachapman reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman
pmachapman deployed to screenshot_diff September 27, 2026 18:54 — with GitHub Actions Active
@pmachapman
pmachapman merged commit 904ed64 into master Sep 27, 2026
29 checks passed
@pmachapman
pmachapman deleted the update/storybook-10.6 branch September 27, 2026 18:56

This branch was successfully deployed

1 active deployment
screenshot_diff — 058639fd Deployed Sep 27, 2026 by pmachapman via Compare Screenshots #974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants