Repository navigation
Fix GPU-decompression notebook - #2977
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
t20100
force-pushed
the
fix-gpu-decompression-notebook
branch
from
October 23, 2026 11:37
2c1de4a to
dc33ab6
Compare
kif
approved these changes
Oct 23, 2026
kif
left a comment
kif
left a comment
Member
There was a problem hiding this comment.
Well spotted. Provides a fix while silx-kit/silx#4757 is underways ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompression and azim. int. do not look to share the queue, this can cause reads before decompression is completed.
This PR proposes minimal changes to sync both queues (notebook not rerun to check performances).
A better fix would be to update silx's
OpenclProcessingto allow sharing the queue.