Repository navigation
silx.gui.plot.tools.tests.test_profile: Replace subtests by parametrization - #4753
Merged
Merged
Conversation
t20100
approved these changes
Oct 23, 2026
| ], | ||
| ) | ||
| def testImageActions(self, imagePlot, roiClass, qapp_utils): | ||
| self.genericRoiTest(imagePlot, roiClass, qapp_utils) |
Member
There was a problem hiding this comment.
maybe bake the 3 tests wrapping genericRoiTest into one.
Member
Author
There was a problem hiding this comment.
That doesn't seem easy unless I am missing something 😅
What did you have in mind?
Member
There was a problem hiding this comment.
Sorry, I read too fast and missed the fact that the first fixture is not always the same, so it's fine as it is.
request.getfixturevalue could be used to do so, but not worth the complexity IMO.
Member
There was a problem hiding this comment.
Sorry, I read too fast and missed the fact that the first fixture is not always the same, so it's fine as it is.
request.getfixturevalue could be used to do so, but not worth the complexity IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)PR summary
pytest.subtestsare only available in pytest 9.0 and this raises issues for the debian packaging.In this PR, the
subtestsare replaced by simple parametrization.AI Disclosure