Conversation
…-jtd spec (RFC 8927 3.3 conformance); align accessor names to documented renames (ruling 15)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation changes align with verified renderer behavior and all tests pass.
Review effort: Lite
Findings: None
What changed in this PR
Updates the ESM code-generation specification to match the normative JTD behavior and current renderer output.
Changes:
- Corrects qualified schema paths.
- Updates Java accessors to
asDouble()andasLong(). - Documentation-only change.
| File | Description |
|---|---|
jtd-esm-codegen/JTD_CODEGEN_SPEC.md |
Aligns documented emission rules with the normative specification and renderer output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the jtd-esm-codegen JTD_CODEGEN_SPEC.md copy with the normative json-java21-jtd spec (ruling 15): qualified guard paths (sp + /elements, /properties, /values, /discriminator; root guard /properties; tags guard /properties/tags/elements) and the documented asDouble/asLong accessor names. The EsmRenderer emitter at HEAD already emits the qualified paths - verified row-by-row against the normative section 6.1 table; the divergence was spec-copy only. Verified: ./mvnw test -pl jtd-esm-codegen -am => BUILD SUCCESS, 359 tests, 0 failures, including the 316-case official validation.json conformance suite in GraalVM JS.