Repository navigation
lowering: native data class fields name their user types - #159
Merged
Merged
Conversation
A field declared as a non-generic user sum type or record now names it in native output, as a string since the union alias comes after the classes (Add._0: "Expr"), instead of Any. mypy accepts it with the same flags, and mypyc can keep the field typed rather than boxing every read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #155/#158. In native output, a data class field declared as a non-generic user sum type or record now names it, as a string forward reference since the union alias comes after the classes:
instead of
Any. Generic types and anything else keepAny.mypy 2.3.1 accepts all three benchmarks with the usual
--allow-redefinition-new --local-partial-types. All single-file examples give identical output natively, andcargo testpasses.Measured (manual
native-benchrun 36367746170, CPython 3.12): expr_eval mypyc 1.37x of hand-written (was 1.40x in #155), collatz 0.08x, map_build 1.32x. The project build step also passed.