Repository navigation
fix: skip truncated a=rtcp SDP lines in ExtractCID - #361
Merged
Merged
Conversation
Malformed "a=rtcp:<port> IN IPx" lines without an address caused a slice-bounds panic. Check the IP start index before slicing (#360).
kYroL01
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtractCID()before slicing the address out ofa=rtcp:<port> IN IPx …so a truncated SDP line no longer panics withslice bounds out of range.a=rtcp:and fall back to the sessionc=IP when the address is missing.a=rtcp:with address, and port-only form.Fixes #360
Test plan
go test -count=1 -run TestExtractCID ./src/decoder/go test -race -count=1 -run TestExtractCID ./src/decoder/a=rtcp:12345 IN IP4SDP no longer crashes heplify