Add defaults maxconn - #233
Merged
Merged
Conversation
xosk31
approved these changes
Sep 21, 2026
xosk31
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for configuring the
maxconnparameter within thedefaultssection of HAProxy configurations.Motivation
HAProxy allows setting a maximum number of concurrent connections per process using the
maxconnparameter. While this is configurable at the frontend level, there are scenarios where operators need to define a global or defaultmaxconnlimit across all proxies that do not explicitly override it. By introducing themaxconnfield to theDefaultsConfigurationstruct, users can now specify a default maximum connection limit directly via the Instance CRD.Changes
Maxconn(*int64) field to theDefaultsConfigurationstruct inapis/proxy/v1alpha1/instance_types.go.Model()method inapis/proxy/v1alpha1/instance_types.goto map this new field to the native HAProxy model (defaults.Maxconn = d.Maxconn).TestDefaultsConfigurationModelWithMaxconnandTestDefaultsConfigurationAddToParserWithMaxconn) inapis/proxy/v1alpha1/instance_types_test.goto verify the correct mapping and generation of themaxconnconfiguration line.DeepCopyIntomethods, and API documentation to reflect the newmaxconnfield.Checklist